Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto assigned transformers for datetime columns don't have the right parameters #1204

Closed
npatki opened this issue Jan 27, 2023 · 0 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Jan 27, 2023

Environment Details

  • SDV version: 1.0.0 (in progress)
  • Python version: 3.8
  • Operating System: Linux (Colab Notebook)

Error Description

For my datetime columns, the metadata looks something like this:

'start_date': {
    'sdtype': 'datetime',
    'datetime_format': '%Y-%m-%d'
},

But when I do auto_assign_transformers, this is what I see:

'start_date': UnixTimestampEncoder(model_missing_values=True)

This doesn't seem right: The datetime_format is missing. I have provided this in the metadata.

This is what I expect to see after auto_assign_transformers:

'start_date': UnixTimestampEncoder(
    datetime_format='%Y-%m-%d', # directly coming from my metadata
)

Steps to reproduce

from sdv.datasets.demo import download_demo
from sdv.single_table import GaussianCopulaSynthesizer

data, metadata = download_demo(
    modality='single_table',
    dataset_name='student_placements_pii'
)

synthesizer = GaussianCopulaSynthesizer(metadata)
synthesizer.auto_assign_transformers(data)
synthesizer.get_transformers()

Other Notes

I'm curious if this could be a root cause for #1203

@npatki npatki added the bug Something isn't working label Jan 27, 2023
@npatki npatki added this to the 1.0.0 milestone Jan 27, 2023
@amontanez24 amontanez24 changed the title Auto assigned transformers for datetime columns don't have the right parameteres Auto assigned transformers for datetime columns don't have the right parameters Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants