Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cached Faker instance to discover if an sdtype is a Faker function. #1405

Closed
pvk-developer opened this issue May 1, 2023 · 0 comments · Fixed by #1406
Closed

Use cached Faker instance to discover if an sdtype is a Faker function. #1405

pvk-developer opened this issue May 1, 2023 · 0 comments · Fixed by #1406
Assignees
@pvk-developer
Labels
maintenance Tasks related to infrastructure & dependencies
Milestone
1.1.0

Comments

@pvk-developer
Copy link
Member

Environment Details

  • SDV version: 1.0.1
  • Python version: Any
  • Operating System: Any

Error Description

Currently an instance is being created each time we are checking wether or not a sdtype is a Faker function. If we use lru_cache to get an instance this will optimize the validation times on larger metadata.
@pvk-developer pvk-developer added the maintenance Tasks related to infrastructure & dependencies label May 1, 2023
@pvk-developer pvk-developer mentioned this issue May 1, 2023
Merged
@amontanez24 amontanez24 added this to the 1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pvk-developer pvk-developer

Labels
maintenance Tasks related to infrastructure & dependencies
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Use cached version of faker rather than instance every time sdv-dev/SDV
2 participants
@amontanez24 @pvk-developer