Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when loading a synthesizer on a previously-saved SDV version #1836

Closed
npatki opened this issue Mar 5, 2024 · 0 comments · Fixed by #1857
Closed

Show warning when loading a synthesizer on a previously-saved SDV version #1836

npatki opened this issue Mar 5, 2024 · 0 comments · Fixed by #1857
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Mar 5, 2024

Problem Description

Consider the following scenario:

  1. I am on the latest version of SDV (1.10.0) and I encounter a bug
  2. I am able to find a workaround so I move on from the bug. I train and save a synthesizer on SDV 1.10.0
  3. In a future SDV version (eg. 1.11.0), I am told that the bug is fixed so I upgrade to the new version
  4. I load in my saved synthesizer from (3) expecting the bug to be fixed --- but it's not!

The scenario is confusing because it's never communicated to me that I cannot simply re-load my synthesizer expecting a bug to be fixed. I must actually create a new synthesizer and re-fit it in order to see the bug fixes.

Expected behavior

Upon loading a synthesizer, show a warning if the synthesizer was created on a previous version of SDV.

>>> synthesizer = HMASynthesizer.load('synthesizer.pkl')
SDV Version Warning: You are currently on SDV version 1.11.0 but this 
synthesizer was created on version 1.10.0. The latest bug fixes and features 
may not be available for this synthesizer. To see these enhancements, 
create and train a new synthesizer on this version.

Additional context

Apply this warning to all synthesizers (available to public and enterprise)

Note that the trained version is available under synthesizer.get_info() -- (the enterprise version may not be -- perhaps we should add this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants