Show warning when loading a synthesizer on a previously-saved SDV version #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvk-developer
requested review from
R-Palazzo and
fealho
and removed request for
amontanez24
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1857 +/- ##
==========================================
+ Coverage 97.32% 97.34% +0.01%
==========================================
Files 51 51
Lines 4823 4858 +35
==========================================
+ Hits 4694 4729 +35
Misses 129 129 ☔ View full report in Codecov by Sentry. |
R-Palazzo
reviewed
Mar 19, 2024
frances-h
reviewed
Mar 20, 2024
sdv/_utils.py
Outdated
| current_public_version = getattr(version, 'public', None) | ||
| current_enterprise_version = getattr(version, 'enterprise', None) | ||
| public_missmatch = current_public_version != synthesizer._fitted_sdv_version | ||
| enterprise_missmatch = current_enterprise_version != synthesizer._fitted_sdv_enterprise_version |
There was a problem hiding this comment.
I think we can't assume loaded synthesizers will have this attribute since it's being added
There was a problem hiding this comment.
This should be addressed now using getattr instead of directly accessing it. a006215
frances-h
approved these changes
Mar 21, 2024
pvk-developer
deleted the
issue-1836-show-warning-when-loading-synthesizer-previously-saved
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1836
CU-86azkp7mu
Added a new attribute to the
synthesizerscalled_fitted_sdv_enterprise_versionwhich will only be added toget_infoif it is notNone.