Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test for HMA1 when working with a single child row per parent row #497

Closed
pvk-developer opened this issue Jul 1, 2021 · 0 comments · Fixed by #524
Closed

Unit test for HMA1 when working with a single child row per parent row #497

pvk-developer opened this issue Jul 1, 2021 · 0 comments · Fixed by #524
Assignees
@pvk-developer
Labels
internal The issue doesn't change the API or functionality
Milestone
0.12.0

Comments

@pvk-developer
Copy link
Member

Problem Description

Within the code of HMA1 ,

SDV/sdv/relational/hma.py

Line 106 in 54fb573

if len(child_rows) == 1:
, is working with an edge case where the length of the child rows is equal to 1. This is because we don't want to learn the distribution for those values, since they will be 0 and will alter the std by a lot.

Do we have a test that goes over this edge case?
@pvk-developer pvk-developer added feature request Request for a new feature pending review labels Jul 1, 2021
@pvk-developer pvk-developer changed the title Unit test for HMA1 when working with a single child Unit test for HMA1 when working with a single child row per parent row Jul 14, 2021
pvk-developer added a commit that referenced this issue Jul 26, 2021
@pvk-developer
Create a test that resolves the issue #497
8bf3a5e
@pvk-developer pvk-developer mentioned this issue Jul 26, 2021
Merged
csala pushed a commit that referenced this issue Jul 28, 2021
@pvk-developer
Integration test that covers a single child row per parent row (#524)
3140c29 
* Create a test that resolves the issue  #497

* Remove break.

* Update test.
@csala csala added internal The issue doesn't change the API or functionality and removed feature request Request for a new feature pending review labels Jul 28, 2021
@csala csala added this to the 0.12.0 milestone Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pvk-developer pvk-developer

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Integration test that covers a single child row per parent row sdv-dev/SDV
2 participants
@csala @pvk-developer