Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the UniqueCombinations constraint #793

Closed
amontanez24 opened this issue May 10, 2022 · 0 comments · Fixed by #795
Closed

Update the UniqueCombinations constraint #793

amontanez24 opened this issue May 10, 2022 · 0 comments · Fixed by #795
Assignees
@fealho
Labels
feature request Request for a new feature
Milestone
0.15.0

Comments

@amontanez24
Copy link
Contributor

Problem Description

As a user, the name UniqueCombinations is misleading since the combinations do not necessarily appear only once.

Expected behavior

  • Rename the UniqueCombinations constraint to FixedCombinations
  • Rename columns parameter to column_names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fealho fealho

Labels
feature request Request for a new feature
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Update UniqueCombinations sdv-dev/SDV
2 participants
@amontanez24 @fealho