Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ColumnFormula Constraint #837

Closed
amontanez24 opened this issue Jun 6, 2022 · 0 comments · Fixed by #847
Closed

Remove the ColumnFormula Constraint #837

amontanez24 opened this issue Jun 6, 2022 · 0 comments · Fixed by #847
Labels
feature request Request for a new feature
Milestone
0.16.0

Comments

@amontanez24
Copy link
Contributor

Problem Description

The changes being made to the CustomConstraint should encompass everything that the ColumnFormula does so there really isn't a need for it anymore.

Expected behavior

  • Delete the ColumnFormula constraint class
  • Delete any related tests
  • Remove it from any parts in the documentation

Additional context

We may end up adding a factory method later that will create post processing classes and that will act as a replacement for the ColumnFormula class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Request for a new feature
Projects
None yet
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Remove the ColumnFormula Constraint sdv-dev/SDV
3 participants
@npatki @amontanez24 @pvk-developer