Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fit, transform and reverse_transform to DataProcessor #947

Closed
amontanez24 opened this issue Aug 10, 2022 · 0 comments
Closed

Add fit, transform and reverse_transform to DataProcessor #947

amontanez24 opened this issue Aug 10, 2022 · 0 comments
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

Problem Description

The DataProcessor class will need to have fit, transform and fit_transform methods.

Expected behavior

  • Add the following methods
    • fit(self, data): Fit the all of the constraints created in the init and a HyperTransformer.

      • We should still handle constraints in the same way and copy logic from Table._fit_transform_constraints
      • The transformers used in the HyperTransformer should be configured/selected using similar rules to what we have now. The handling of anonymization will be done in a later issue.
    • transform(self, data, is_condition): Transform the data using the self.constraints and self.hyper_transformer in that order.

      • We should copy most of the functionality from here. We just won’t need to do the anonymization step.
    • reverse_transform(self, data): Reverse transform the data using the self.constraints and self.hyper_transformer in that reverse order.

      • We should copy most of the functionality from here. Again we can just avoid the pii related stuff.

Additional context

We may consider adding another method called transform_conditions that does all the logic for condition transforming separately. This way the tranform method won't need the is_Condition parameter, and all the if statements in our code designed to handle this special case can be removed and their logic can be broken up into separate methods. This should be more readable.

@amontanez24 amontanez24 added the feature request Request for a new feature label Aug 10, 2022
@amontanez24 amontanez24 added this to the 1.0.0 milestone Aug 16, 2022
@amontanez24 amontanez24 self-assigned this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

1 participant