Add transformer methods to PARSynthesizer
#1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
commented
Nov 28, 2022
| @@ -167,6 +167,23 @@ def preprocess(self, data): | |||
| self.update_transformers(sequence_key_transformers) | |||
| return super().preprocess(data) | |||
|
|
|||
| def update_transformers(self, column_name_to_transformer): | |||
There was a problem hiding this comment.
I'm only adding update_transformers because the other two methods are already implemented in base.
There was a problem hiding this comment.
I think this should be good. Can you double check that the correct transformers are assigned when calling auto_assign_transformers? For PAR, everything should be None except for datetimes
fealho
requested review from
pvk-developer and
amontanez24
and removed request for
a team
amontanez24
approved these changes
Nov 28, 2022
| @@ -167,6 +167,23 @@ def preprocess(self, data): | |||
| self.update_transformers(sequence_key_transformers) | |||
| return super().preprocess(data) | |||
|
|
|||
| def update_transformers(self, column_name_to_transformer): | |||
There was a problem hiding this comment.
I think this should be good. Can you double check that the correct transformers are assigned when calling auto_assign_transformers? For PAR, everything should be None except for datetimes
pvk-developer
approved these changes
Nov 29, 2022
Comment on lines
-35
to
-38
| metadata=metadata, | ||
| default_distribution='norm', | ||
| enforce_rounding=False | ||
| ) |
There was a problem hiding this comment.
🤔 wondering why lint did not capture it
amontanez24
pushed a commit
that referenced
this pull request
Dec 21, 2022
amontanez24
pushed a commit
that referenced
this pull request
Feb 17, 2023
amontanez24
pushed a commit
that referenced
this pull request
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1082.