Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when trying to get distributions from non-parametric models #1633

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

frances-h
Copy link
Contributor

@frances-h frances-h commented Oct 17, 2023

CU-86ay9gt16

@frances-h frances-h requested a review from a team as a code owner October 17, 2023 15:16
@frances-h frances-h requested review from fealho and pvk-developer and removed request for a team October 17, 2023 15:16
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c7a5024) 97.11% compared to head (e6ad43f) 97.11%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1633   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files          48       48           
  Lines        4198     4200    +2     
=======================================
+ Hits         4077     4079    +2     
  Misses        121      121           
Files Coverage Δ
sdv/multi_table/base.py 91.28% <100.00%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the issue in the description (although I'm presuming there's none, in which case ignore this).

@frances-h frances-h merged commit 4d4ed3e into main Oct 23, 2023
74 checks passed
@frances-h frances-h deleted the get_learned_distributions-better-error branch October 23, 2023 19:42
@amontanez24 amontanez24 added this to the 1.6.0 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants