Metadata auto-detection should ensure primary keys are unique (special sdtypes are not exempt from this rule!) #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
approved these changes
Mar 27, 2024
frances-h
approved these changes
Mar 27, 2024
sdv/metadata/single_table.py
Outdated
| @@ -525,6 +525,8 @@ def _detect_columns(self, data): | |||
| for field in data: | |||
| column_data = data[field] | |||
| has_nan = column_data.isna().any() | |||
| is_unique = column_data.nunique() == len(column_data) | |||
| valid_potential_primary_key = is_unique and not has_nan | |||
There was a problem hiding this comment.
Can we use column_data.is_unique here instead of using nunique?
There was a problem hiding this comment.
Yes, good point, done in bbaeac1
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1876 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 51 51
Lines 4907 4908 +1
=======================================
+ Hits 4784 4785 +1
Misses 123 123 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86azuyq0t
Resolve #1871