Create unique id for each synthesizer #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvk-developer
force-pushed
the
issue-1902-create-unique-id-for-each-synthesizer
branch
from
e13f825
to
bcddd7f
Compare
pvk-developer
requested review from
frances-h and
amontanez24
and removed request for
a team
pvk-developer
force-pushed
the
issue-1902-create-unique-id-for-each-synthesizer
branch
from
bcddd7f
to
36f3cb1
Compare
amontanez24
reviewed
Apr 17, 2024
sdv/_utils.py
Outdated
| """ | ||
| class_name = synthesizer.__class__.__name__ | ||
| synth_version = version.public | ||
| unique_id = str(uuid.uuid4()).split('-')[-1] |
There was a problem hiding this comment.
If we take only a portion of it, it's not guaranteed to be unique anymore right?
There was a problem hiding this comment.
Yeah, I think that a portion is not guarateed to be unique and the odds of it repeating are small but there are. Should we use the entire UUID4 ?
There was a problem hiding this comment.
Yeah I think we should
amontanez24
approved these changes
Apr 17, 2024
pvk-developer
deleted the
issue-1902-create-unique-id-for-each-synthesizer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1902
CU-86b00mxjz
This is how the
IDSlook :I'm printing both
instanceandidjust in case we wanted to change therepresentationto be the id of the synthesizer.