Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VineCopula is not working NonImplementedError for pdf and cdf #370

Closed
grechasneak opened this issue Nov 13, 2023 · 2 comments
Closed

VineCopula is not working NonImplementedError for pdf and cdf #370

grechasneak opened this issue Nov 13, 2023 · 2 comments
Labels
bug There is an error in the code that needs to be fixed resolution:WAI The software is working as intended

Comments

@grechasneak
Copy link

Environment Details

  • Copulas version: 3.10.4
  • Python version: 1.4.2
  • Operating System: Linux

Error Description

Trying to fit a vine copula to a pandas dataframe with 3 columns and then get the pdf for each row in the dataset. I am getting a NonImplementedError.

image

@grechasneak grechasneak added bug There is an error in the code that needs to be fixed new Automatic label applied to new issues labels Nov 13, 2023
@npatki
Copy link

npatki commented Nov 15, 2023

Hi @grechasneak, a NotImplementedError indicates that the functionality does not exist for the type of Copula you're using.

I would recommend referring to the API docs for Vine Copulas. In the docs, I don't see any method called probability_density. Did you meant to use a different method such as get_likelihood?

Alternatively, if you think probability density is something that's missing, we could turn this into a feature request for adding such functionality. We prioritize feature requests based on demand and the importance to your projects. So any other information about your project will be useful. For example, what is the goal of the project? Are you trying to predict something for the selected weather?

@npatki npatki added under discussion Issue is currently being discussed and removed new Automatic label applied to new issues labels Nov 15, 2023
@npatki
Copy link

npatki commented Apr 17, 2024

Closing this issue off since it has been stale for some time. Please feel free to reply if there is more to discuss and I can always re-open the issue for continued investigation.

@npatki npatki closed this as completed Apr 17, 2024
@npatki npatki added resolution:WAI The software is working as intended and removed under discussion Issue is currently being discussed labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug There is an error in the code that needs to be fixed resolution:WAI The software is working as intended
Projects
None yet
Development

No branches or pull requests

2 participants