Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade UML diagrams to the new version of PlantUML #200

Closed
damithc opened this issue Jul 18, 2023 · 6 comments · Fixed by #202
Closed

Upgrade UML diagrams to the new version of PlantUML #200

damithc opened this issue Jul 18, 2023 · 6 comments · Fixed by #202
Labels
p.High prefer to be fixed in the next few releases

Comments

@damithc
Copy link
Contributor

damithc commented Jul 18, 2023

Seems the new version has some breaking changes, as the MarkBind team found (some info here) e.g., no need for GraphViz on Windows

Both diagrams and Dev Guide might needs updating.

@damithc damithc added the p.High prefer to be fixed in the next few releases label Jul 18, 2023
@damithc
Copy link
Contributor Author

damithc commented Jul 18, 2023

@Eclipse-Dominator can have a look?

@Eclipse-Dominator
Copy link
Contributor

Eclipse-Dominator commented Jul 27, 2023

Do we adapt to the newer lighter-colored theme or should we preserve the old color scheme?

The most noticeable theme change is the border color change as well as the background change

image


For now I will use the old theme version.

@damithc
Copy link
Contributor Author

damithc commented Jul 27, 2023

@Eclipse-Dominator I think there is no good reason to keep the old style. We can go with the new default style.

@Eclipse-Dominator
Copy link
Contributor

Eclipse-Dominator commented Jul 27, 2023

I think it might be better to stick with the old theme / rose theme for now as some of the color scheme changes in style.puml as some of the diagrams are based on the old color scheme.

@damithc
Copy link
Contributor Author

damithc commented Jul 27, 2023

I think it might be better to stick with the old theme / rose theme for now as some of the color scheme changes in style.puml as some of the diagrams are based on the old color scheme.

I see. I would like to see the difference before making the decision. It is ideal if new batches of student's don't need to follow the legacy stuff at all, as they are unnecessary complications for them.

@Eclipse-Dominator
Copy link
Contributor

I will provide a separate PR to display the changes in color schemes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p.High prefer to be fixed in the next few releases
Projects
None yet
2 participants