Storage: Add backupAddressBook(ReadOnlyAddressBook) #594

yamgent · 2017-07-28T07:07:09Z

Part of #784. Rebased, fixed the compilation error.

Proposed commit message:

Storage saves to a single file path.

Users may want to do a backup of the address book in a different
location.

Let's add Storage#backupAddressBook(ReadOnlyAddressBook).

Note: This PR is used as an example for future developers. Do not merge!

mention-bot · 2017-07-28T07:07:10Z

@yamgent, thanks for your PR! By analyzing the history of the files in this pull request, we identified @damithc, @yl-coder and @chao1995 to be potential reviewers.

CanIHasReview-bot · 2018-02-08T04:17:15Z

v1

@yamgent submitted v1 for review.

[v1 1/1] Storage: Add backupAddressBook(ReadOnlyAddressBook)

(📚 Archive)

Checkout this PR version locally

git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/594/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

Zhiyuan-Amos

As spoken, rmb to update https://github.com/se-edu/addressbook-level4/blob/master/docs/DeveloperGuide.adoc#storage-component to update the logic in XmlAddressBookStorage too.

Zhiyuan-Amos · 2018-02-08T04:24:50Z

src/main/java/seedu/address/storage/StorageManager.java

@@ -77,6 +77,10 @@ public void saveAddressBook(ReadOnlyAddressBook addressBook, String filePath) th
        addressBookStorage.saveAddressBook(addressBook, filePath);
    }

+    @Override
+    public void backupAddressBook(ReadOnlyAddressBook addressBook) throws IOException {
+        saveAddressBook(addressBook, addressBookStorage.getAddressBookFilePath() + "-backup.xml");


This method should be calling addressBookStorage#backupAddressBook(ReadOnlyAddressBook) instead :P

CanIHasReview-bot · 2018-02-08T05:10:21Z

v2

@yamgent submitted v2 for review.

[v2 1/1] Storage: Add backupAddressBook(ReadOnlyAddressBook)

(📚 Archive) (📈 Interdiff between v1 and v2)

Checkout this PR version locally

git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/594/2/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

Zhiyuan-Amos

💯

Zhiyuan-Amos · 2018-02-13T16:00:10Z

@yamgent this PR is failing 1 test :<

CanIHasReview-bot · 2018-08-09T05:46:46Z

v3

@yamgent submitted v3 for review.

[v3 1/1] Storage: Add backupAddressBook(ReadOnlyAddressBook)

(📚 Archive) (📈 Interdiff between v2 and v3) (📈 Range-Diff between v2 and v3)

Checkout this PR version locally

git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/594/3/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

yamgent · 2018-08-09T07:05:37Z

Changelog:

Because we changed the way we handled paths (from String to Path), we must now use the Paths class to generate the backup file path:

addressbook-level4/src/main/java/seedu/address/storage/XmlAddressBookStorage.java

Line 66 in dea2619

saveAddressBook(addressBook, Paths.get(filePath.toString() + ".backup"));

Zhiyuan-Amos · 2018-08-17T05:09:44Z

src/main/java/seedu/address/storage/XmlAddressBookStorage.java

@@ -60,6 +61,11 @@ public Path getAddressBookFilePath() {
        }
    }

+    @Override
+    public void backupAddressBook(ReadOnlyAddressBook addressBook) throws IOException {
+        saveAddressBook(addressBook, Paths.get(filePath.toString() + ".backup"));


I'm wondering whether the backup Path should be stored in a private final field, to be assigned in the constructor.

This is so that we don't have to call Paths.get whenever this method is called.

CanIHasReview-bot · 2018-08-18T12:20:16Z

v4

@yamgent submitted v4 for review.

[v4 1/1] Storage: Add backupAddressBook(ReadOnlyAddressBook)

(📚 Archive) (📈 Interdiff between v3 and v4) (📈 Range-Diff between v3 and v4)

Checkout this PR version locally

git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/594/4/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

yamgent · 2018-08-18T12:34:46Z

src/main/java/seedu/address/storage/XmlAddressBookStorage.java


    public XmlAddressBookStorage(Path filePath) {
        this.filePath = filePath;
+        this.backupFilePath = Paths.get(filePath.toString() + ".backup");


Shouldn't use this. here, my bad.

Storage saves to a single file path. Users may want to do a backup of the address book in a different location. Let's add Storage#backupAddressBook(ReadOnlyAddressBook).

CanIHasReview-bot · 2018-08-18T13:06:48Z

v5

@yamgent submitted v5 for review.

[v5 1/1] Storage: Add backupAddressBook(ReadOnlyAddressBook)

(📚 Archive) (📈 Interdiff between v4 and v5) (📈 Range-Diff between v4 and v5)

Checkout this PR version locally

git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/594/5/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

yamgent changed the title ~~Storage: Add backupAddressBook()~~ Storage: Add backupAddressBook(ReadOnlyAddressBook) Jul 28, 2017

yamgent force-pushed the getting-started-storage branch from dca915a to c30e829 Compare July 28, 2017 07:07

yamgent closed this Jul 29, 2017

yamgent added the pr.Answer Pull request is answer for a tutorial in developer guide. Do not actually merge. label Jan 20, 2018

yamgent reopened this Jan 20, 2018

yamgent force-pushed the getting-started-storage branch 2 times, most recently from 8e692f1 to a95b7df Compare January 20, 2018 02:30

yamgent added the s.Ongoing label Jan 20, 2018

Zhiyuan-Amos mentioned this pull request Jan 24, 2018

Rebase PRs used in suggested programming tasks #784

Closed

yamgent force-pushed the getting-started-storage branch from a95b7df to e02c15c Compare February 4, 2018 05:56

CanIHasReview-bot added s.ToReview and removed s.Ongoing labels Feb 8, 2018

Zhiyuan-Amos reviewed Feb 8, 2018

View reviewed changes

Zhiyuan-Amos added s.Ongoing and removed s.ToReview labels Feb 8, 2018

yamgent force-pushed the getting-started-storage branch 3 times, most recently from 9229461 to 9356bf3 Compare February 8, 2018 04:39

CanIHasReview-bot added s.ToReview and removed s.Ongoing labels Feb 8, 2018

Zhiyuan-Amos approved these changes Feb 8, 2018

View reviewed changes

Zhiyuan-Amos requested a review from damithc February 8, 2018 05:13

damithc approved these changes Feb 8, 2018

View reviewed changes

Zhiyuan-Amos removed the s.ToReview label Feb 8, 2018

Zhiyuan-Amos added the s.Ongoing label Feb 13, 2018

yamgent force-pushed the getting-started-storage branch from 875c904 to 5beb949 Compare August 9, 2018 03:06

yamgent added the s.Ongoing label Aug 9, 2018

yamgent force-pushed the getting-started-storage branch from 5beb949 to dea2619 Compare August 9, 2018 05:39

CanIHasReview-bot added s.ToReview and removed s.Ongoing labels Aug 9, 2018

yamgent requested a review from a team August 9, 2018 05:47

yamgent requested a review from Zhiyuan-Amos August 16, 2018 12:06

Zhiyuan-Amos reviewed Aug 17, 2018

View reviewed changes

yamgent force-pushed the getting-started-storage branch from dea2619 to ff7373c Compare August 18, 2018 12:08

yamgent added s.Ongoing and removed s.ToReview labels Aug 18, 2018

CanIHasReview-bot added s.ToReview and removed s.Ongoing labels Aug 18, 2018

yamgent requested a review from a team August 18, 2018 12:20

yamgent commented Aug 18, 2018

View reviewed changes

Storage: Add backupAddressBook(ReadOnlyAddressBook)

931a592

Storage saves to a single file path. Users may want to do a backup of the address book in a different location. Let's add Storage#backupAddressBook(ReadOnlyAddressBook).

yamgent force-pushed the getting-started-storage branch from ff7373c to 931a592 Compare August 18, 2018 12:38

yamgent added s.Ongoing and removed s.ToReview labels Aug 18, 2018

CanIHasReview-bot added s.ToReview and removed s.Ongoing labels Aug 18, 2018

Zhiyuan-Amos approved these changes Aug 18, 2018

View reviewed changes

yamgent requested a review from damithc August 19, 2018 02:11

damithc approved these changes Aug 19, 2018

View reviewed changes

yamgent removed the s.ToReview label Aug 19, 2018

damithc closed this Dec 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Storage: Add backupAddressBook(ReadOnlyAddressBook) #594

Storage: Add backupAddressBook(ReadOnlyAddressBook) #594

yamgent commented Jul 28, 2017 •

edited

mention-bot commented Jul 28, 2017

CanIHasReview-bot commented Feb 8, 2018

Zhiyuan-Amos left a comment

Zhiyuan-Amos Feb 8, 2018

CanIHasReview-bot commented Feb 8, 2018

Zhiyuan-Amos left a comment

Zhiyuan-Amos commented Feb 13, 2018

CanIHasReview-bot commented Aug 9, 2018

yamgent commented Aug 9, 2018

Zhiyuan-Amos Aug 17, 2018

CanIHasReview-bot commented Aug 18, 2018

yamgent Aug 18, 2018

CanIHasReview-bot commented Aug 18, 2018

Storage: Add backupAddressBook(ReadOnlyAddressBook) #594

Storage: Add backupAddressBook(ReadOnlyAddressBook) #594

Conversation

yamgent commented Jul 28, 2017 • edited

mention-bot commented Jul 28, 2017

CanIHasReview-bot commented Feb 8, 2018

v1

Zhiyuan-Amos left a comment

Choose a reason for hiding this comment

Zhiyuan-Amos Feb 8, 2018

Choose a reason for hiding this comment

CanIHasReview-bot commented Feb 8, 2018

v2

Zhiyuan-Amos left a comment

Choose a reason for hiding this comment

Zhiyuan-Amos commented Feb 13, 2018

CanIHasReview-bot commented Aug 9, 2018

v3

yamgent commented Aug 9, 2018

Zhiyuan-Amos Aug 17, 2018

Choose a reason for hiding this comment

CanIHasReview-bot commented Aug 18, 2018

v4

yamgent Aug 18, 2018

Choose a reason for hiding this comment

CanIHasReview-bot commented Aug 18, 2018

v5

yamgent commented Jul 28, 2017 •

edited