Skip to content
This repository has been archived by the owner on Mar 5, 2023. It is now read-only.

Add eclipse project files #43 #92

Merged
merged 7 commits into from
Sep 26, 2016
Merged

Conversation

m133225
Copy link
Contributor

@m133225 m133225 commented Sep 25, 2016

Fixes #43

@m133225
Copy link
Contributor Author

m133225 commented Sep 25, 2016

@damithc Added a eclipse plugin for gradle and attempted to set it the project on eclipse. Do verify if they are working.

<archive path="/Users/m133225/.gradle/caches/modules-2/files-2.1/org.testfx/testfx-junit/4.0.4-alpha/6bcea501014538d3d6c375dc5468915f8771d469/testfx-junit-4.0.4-alpha.jar" />
</library>
<library name="Gradle: org.testfx:testfx-legacy:4.0.4-alpha">
<archive path="/Users/m133225/.gradle/caches/modules-2/files-2.1/org.testfx/testfx-legacy/4.0.4-alpha/8cda3025db09491282aedec6427dc71c4b445cbf/testfx-legacy-4.0.4-alpha.jar" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has your username. Will not work for others?

@m133225
Copy link
Contributor Author

m133225 commented Sep 25, 2016

Removed them, probably some incorrect files generated by IDEA's export functionality, does not seem to affect anything.

@m133225
Copy link
Contributor Author

m133225 commented Sep 25, 2016

Tried clearing gradle cache before re-importing the project. Seems to download the dependencies upon import. A simple Right-click > Gradle> Refresh should also recheck the dependencies. (Can't verify the exact steps at the moment since it is taking rather long to re-download all gradle AND project dependencies.)

EDIT: It's Right-click on project > Gradle> Refresh Gradle Project

@@ -0,0 +1 @@
null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these two files needed?

@damithc
Copy link
Contributor

damithc commented Sep 25, 2016

Worked for me. Can go ahead and merge.

@damithc
Copy link
Contributor

damithc commented Sep 26, 2016

I'm getting a few random test failures though. Seem to pass upon rerunning.
guitests.AddCommandTest
guitests.SelectCommandTest

@m133225
Copy link
Contributor Author

m133225 commented Sep 26, 2016

Yes I think that happened when I first ran them too yesterday. Haven't looked through the test codes for that. Should I revert that commit?

@damithc
Copy link
Contributor

damithc commented Sep 26, 2016

Didn't happen with IDEA though. So may be Eclipse hogs more resources which slows down the GuiTests?

@damithc
Copy link
Contributor

damithc commented Sep 26, 2016

I've added some delays which seems to solve the problem, at least on my machine. Let's merge this so that I can get tutors to test it.

@m133225 m133225 merged commit d21db89 into master Sep 26, 2016
@m133225 m133225 deleted the 43-add-eclipse-project-files branch September 26, 2016 03:45
@m133225 m133225 mentioned this pull request Sep 26, 2016
leongshengmin added a commit to leongshengmin/addressbook-level4 that referenced this pull request Nov 1, 2018
Geraldcdx pushed a commit to Geraldcdx/addressbook-level4 that referenced this pull request Nov 3, 2018
[v1.3] Integrate authentication into all commands and edit test cases
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants