This repository has been archived by the owner on Mar 5, 2023. It is now read-only.
ConfigTest: Remove unused ExpectedException #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConfigTest contains an unused ExpectedException. It appears that the ExpectedException was first introduced in [1]. However, since its introduction, there have been no tests within ConfigTest that potentially throws an expected exception. Hence, to make our code tidier and to remove unnecessary code, let's remove the ExpectedException together with their imports. [1] se-edu@75942c9
|
Click here to submit a new iteration when this PR is ready for review. See this repository's contribution guide for more information. |
v1@sijie123 submitted v1 for review. Checkout this PR version locallygit fetch https://github.com/se-edu/addressbook-level4.git refs/pr/985/1/head:BRANCHNAMEwhere |
pyokagan
approved these changes
Mar 13, 2019
There was a problem hiding this comment.
ConfigTest: Remove unused ExpectedException ConfigTest contains an unused ExpectedException. It appears that the ExpectedException was first introduced in [1]. However, since its introduction, there have been no tests within ConfigTest that potentially throws an expected exception. Hence, to make our code tidier and to remove unnecessary code, let's remove the ExpectedException together with their imports. [1] https://github.com/se-edu/addressbook-level4/commit/75942c90c04ff0469d5bb26873b85cd094f37797
This is indeed correct, but it seems like a very long-winded way of saying:
ConfigTest: remove unused ExpectedException
The tests in ConfigTest do not use the ExpectedException.
Remove it.
I don't think it is a problem, but I'm just mentioning it in case I
accidentally gave the impression that commit messages must always be a few
paragraphs long :-S.
damithc
approved these changes
Mar 14, 2019
lycjackie
added a commit
to CS2113-AY1819S2-T09-1/main
that referenced
this pull request
Mar 18, 2019
…nfigTest (#88) Upstream se-edu/addressbook-level4@7c2e953 removed an unused ExpectedException to make the codebase tidier and remove unnecessary code. Let's follow and merge the changes from se-edu#985 into master branch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigTest contains an unused ExpectedException. It appears that the
ExpectedException was first introduced in [1].
However, since its introduction, there have been no tests within
ConfigTest that potentially throws an expected exception.
Hence, to make our code tidier and to remove unnecessary code, let's
remove the ExpectedException together with their imports.
[1] 75942c9