Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add article on NumPy #168

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Add article on NumPy #168

merged 3 commits into from
Mar 16, 2020

Conversation

Parcly-Taxel
Copy link
Contributor

@Parcly-Taxel Parcly-Taxel commented Mar 8, 2020

Fixes #167.

I tried to make sure the article wasn't a tutorial on how to use NumPy, but rather what are the objects found in NumPy.

Technically not part of software engineering per se, but it does discuss
the making of an efficient data type in Python.
damithc
damithc previously requested changes Mar 9, 2020
Copy link
Contributor

@damithc damithc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Parcly-Taxel . I like how the article is short and to the point. I've added some suggestions.

contents/python/numpy.md Outdated Show resolved Hide resolved
contents/python/numpy.md Show resolved Hide resolved
contents/python/numpy.md Outdated Show resolved Hide resolved
contents/python/numpy.md Outdated Show resolved Hide resolved
contents/python/numpy.md Show resolved Hide resolved
contents/python/numpy.md Outdated Show resolved Hide resolved
@Parcly-Taxel Parcly-Taxel dismissed damithc’s stale review March 9, 2020 13:46

All issues resolved

Copy link
Contributor

@damithc damithc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damithc
Copy link
Contributor

damithc commented Mar 11, 2020

I'll leave this here for a few more days in case someone else would like to add comments. If there are no further comments, I'll merge it sometime next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NumPy article
2 participants