New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page for Angular #76
Conversation
@RonakLakhotia The structure looks fine. Can proceed to get peer reviews. Remember to credit original source when reusing assets from elsewhere. |
@jacoblipech can review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It is quite well-documented, just certain comments to consider. It will be good if you can read through one more time to check for line spacing, missing comma and minor grammar errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay! LGTM! minor spacing problem which you can settle or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few quick comments to the top portion. Take another critical look at the rest yourself and fix things that I'm likely to object to, based on my current comments. For example, don't make expansive claims as if you are selling Angular. Give an independent unbiased view.
If you want to use marketing claims in the article e.g., effortless, trivial, etc., simply quote the claim from a credible source, even Angular website themselves, and cite the source. That way, you are not the one making the claim. |
Ideal, avoid using the term. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A preliminary review of the top portion. Revise the whole article to match the quality indicated by the review comments. Writing is hard.; buckle down for a long ride :-p
@jacoblipech can do another review as the content has changed since your last review? Refer my review comments and calibrate your review to that depth. The deeper your review is, the better the final outcome will be. |
Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good effort in the writeup! Refer to the suggestions made 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Despite using Angular in Teammates, I still learnt some new knowledge from reading it! Minor nits. Also, the "Given below..." phrasings feel quite weird to me but it may be just me, so up to you!
@jacoblipech appreciate your review and inputs in this page! |
@tanhengyeow sorry for the nagging, but still waiting on your final approval. :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better now, great job! Just some nits.
Also, in your first section What is Angular?
, you mentioned about Templates, Components, and Dependency Injection. I feel it might nice to put clear sub-headings for them so that it is easier to follow.
@tanhengyeow thanks for the suggestions. Added clear headers for templates components and DI. |
@tanhengyeow could you look at it again, just a bit worried about the time constraints :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some final nits, thanks for the effort put into this chapter!
@jacoblipech @tanhengyeow appreciate your reviews and thank you for the effort put into this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now. As we spent so much time on this, why not make it near perfect so that it can serve a a model for future authors? here are few more things to consider.
@damithc thanks for suggestions 👍 Updated the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More nits
Merged and deployed. Good work @RonakLakhotia |
Fixes #70