Add support for QEMU virt AArch64 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a naive memcpy() implementation in the loader for copying data from the loader image to the right region in physical memory. The compiler, understandibly, decides to optimise this (given we are passing -O3). However, the compiler optimizes this loop into vector/FPU instructions which I believe fails on platforms that do not already have their FPU initialised, such as QEMU ARM virt. Most hardware platforms have their FPU initialised by U-Boot which runs before the Microkit loader which is why it has not been a problem until now. Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
qemu_arm_virt
branch
3 times, most recently
from
92f3e11
to
ab9f5b6
Compare
Ivan-Velickovic
changed the title
Ivan-Velickovic
force-pushed
the
qemu_arm_virt
branch
from
ab9f5b6
to
3293abd
Compare
Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
qemu_arm_virt
branch
from
3293abd
to
440281d
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.