Skip to content

Commit

Permalink
libsel4: Always usage IPC buffer for invocations (SELFOUR-381)
Browse files Browse the repository at this point in the history
Currently the syscall invocations may throw away error information
in an unretrievable way if they attempt to avoid using the IPC buffer
  • Loading branch information
AdrianDanis committed Dec 16, 2015
1 parent 4056ad4 commit 5271925
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 23 deletions.
22 changes: 0 additions & 22 deletions libsel4/Kconfig
Expand Up @@ -38,28 +38,6 @@ config LIB_SEL4_HAVE_REGISTER_STUBS
as a result these stubs are known to be broken, and are disabled,
at -O0

if LIB_SEL4_HAVE_REGISTER_STUBS || !(ARCH_ARM)
config LIB_SEL4_STUBS_USE_IPC_BUFFER_ONLY
bool "use only IPC buffer for syscalls"
depends on LIB_SEL4
default n
help
When generating syscall wrappers, only use the IPC buffer for
marshalling and unmarshalling arguments. Without this option set,
arguments will be passed in registers where possible for better
performance.
endif

if !(LIB_SEL4_HAVE_REGISTER_STUBS || !(ARCH_ARM))
menu "libsel4 hidden"
visible if false
config LIB_SEL4_STUBS_USE_IPC_BUFFER_ONLY
bool "Use only IPC buffer for syscalls"
depends on LIB_SEL4
default y
endmenu
endif

config HAVE_LIB_SEL4
bool
endmenu
2 changes: 1 addition & 1 deletion libsel4/Makefile
Expand Up @@ -85,5 +85,5 @@ include/interfaces/sel4_client.h: \
@mkdir -p $(dir $@)
@${CHANGED_PATH} $@ \
python ${SOURCE_DIR}/tools/syscall_stub_gen.py \
$(if ${CONFIG_LIB_SEL4_STUBS_USE_IPC_BUFFER_ONLY},--buffer,) \
--buffer \
-a $(ARCH) -o $@ $^

0 comments on commit 5271925

Please sign in to comment.