Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates manual #1140

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Minor updates manual #1140

merged 1 commit into from
Nov 29, 2023

Conversation

bbrcknl
Copy link
Contributor

@bbrcknl bbrcknl commented Nov 24, 2023

Fix most TODOs in the seL4 manual.
Remaining TODOs:

  • 6.4.1 Arm - needs more detail
  • 10.7.10.2 Inject IRQ - needs a description
  • 10.7.10.3 Read Registers - needs a return value description and a description of the function
  • 10.7.10.3 Read Registers - needs a description

@mbrcknl mbrcknl requested a review from Indanz November 24, 2023 00:07
@Ivan-Velickovic
Copy link
Contributor

Regarding 6.4.1, there's a list of things to mention here #1083 (if you weren't aware of that issue already) :).

Indanz
Indanz requested changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@Indanz Indanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all good improvement, I'll review the rest later.

libsel4/arch_include/arm/interfaces/sel4arch.xml Outdated Show resolved Hide resolved
libsel4/arch_include/arm/interfaces/sel4arch.xml Outdated Show resolved Hide resolved
libsel4/arch_include/x86/interfaces/sel4arch.xml Outdated Show resolved Hide resolved
libsel4/include/interfaces/sel4.xml Outdated Show resolved Hide resolved
Indanz
Indanz requested changes Nov 24, 2023
View reviewed changes
libsel4/include/interfaces/sel4.xml Outdated Show resolved Hide resolved
libsel4/sel4_arch_include/x86_64/interfaces/sel4arch.xml Outdated Show resolved Hide resolved
manual/parts/threads.tex Outdated Show resolved Hide resolved
Indanz
Indanz approved these changes Nov 27, 2023
View reviewed changes
libsel4/include/interfaces/sel4.xml Outdated Show resolved Hide resolved
@Indanz
Copy link
Contributor

Indanz commented Nov 27, 2023

Ignore the gitling error, we're going to squash all commits before merging anyway.

@bbrcknl bbrcknl marked this pull request as ready for review November 29, 2023 04:23
@bbrcknl bbrcknl force-pushed the minor_updates_manual branch 2 times, most recently from c40159c to f0c0135 Compare November 29, 2023 05:38
update some manual todos
304c5c9 
Signed-off-by: Birg <bbrcknl@github.com>
@bbrcknl
Copy link
Contributor Author

bbrcknl commented Nov 29, 2023

@Indanz Can you pls merge this branch? I don't have write access.

@Indanz Indanz merged commit 391bfb1 into seL4:master Nov 29, 2023
41 checks passed
@bbrcknl bbrcknl deleted the minor_updates_manual branch November 30, 2023 21:46
@lsf37 lsf37 added the docs Manual and other documentation label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Indanz Indanz Indanz approved these changes

Assignees
No one assigned
Labels
docs Manual and other documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbrcknl @Ivan-Velickovic @Indanz @lsf37