manual: document write-only pages #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan-Velickovic
force-pushed
the
document_write_only_pages
branch
from
6ee764b
to
fd3d7a4
Compare
Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
document_write_only_pages
branch
from
fd3d7a4
to
240b20e
Compare
axel-h
reviewed
Jun 11, 2024
| @@ -169,7 +169,8 @@ \subsection{Page} | |||
| are specified with an argument of type \texttt{seL4\_CapRights} given to the mapping invocation. If | |||
| the capability does not have sufficient permissions to authorise the given mapping, the mapping | |||
| permissions are silently downgraded. Specific mapping permissions are dependent on the architecture | |||
| and are documented in the \autoref{sec:api_reference} for each function. | |||
| and are documented in the \autoref{sec:api_reference} for each function. On all architectures, | |||
There was a problem hiding this comment.
Maybe weaken this a bit.
Suggested change
| and are documented in the \autoref{sec:api_reference} for each function. On all architectures, | |
| and are documented in the \autoref{sec:api_reference} for each function. On all currently supported architectures, |
There was a problem hiding this comment.
I don't think that weakening is necessary, we're clearly not talking about all architectures in the world, just the ones seL4 runs on. Fewer words are usually clearer.
lsf37
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.