Cleanout libsel4/include/config.h configurations #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingerino
approved these changes
Jul 9, 2021
axel-h
approved these changes
Jul 9, 2021
autoconf.h is expected to contain all defined config options for an seL4 build configuration. Having these redefinitions were leftover from when the verification build system didn't produce an autoconf.h file and set the config separately. Its more likely that these defaults would incorrectly hide an include path misconfiguration and produce settings that are inconsistent with the kernel's configuration. Signed-off-by: Kent McLeod <kent@kry10.com>
CONFIG_ENABLE_SMP_SUPPORT has the correct namespace for a kernel config option. Signed-off-by: Kent McLeod <kent@kry10.com>
CONFIG_AARCH64_VSPACE_S2_START_L1 has the correct namespace for a kernel config option. Signed-off-by: Kent McLeod <kent@kry10.com>
Define CONFIG_KERNEL_LOG_BUFFER in the same way as all other kernel config options so that it is present in autoconf.h Signed-off-by: Kent McLeod <kent@kry10.com>
kent-mcleod
force-pushed
the
kent/config
branch
from
5b14257
to
97f3bfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally libsel4/include/config.h was an internal kernel config file and had default option definitions to allow older build systems to compile the kernel, ie for L4V. The original commit (1ce721b#diff-75acece24054e5d68d207058b0b3d8305249d0a4bfbfb1d753f93a84d2eb402e) that moved this header file to libsel4 indicated that it wasn't supposed to be depended on outside of code testing and benchmarking. This PR cleans up the config definitions so that they can be more consistently depended on (seL4/seL4_tools#96).
These changes are binary compatible but source incompatible because the old config names,
ENABLE_SMP_SUPPORTandAARCH64_VSPACE_S2_START_L1no longer exist and must be renamed toCONFIG_ENABLE_SMP_SUPPORTandCONFIG_AARCH64_VSPACE_S2_START_L1.