-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ARM CPUID printing #107
Conversation
7e2e159
to
80d87c8
Compare
80d87c8
to
2fbba70
Compare
This patch fixes A35, but breaks a lot of the rest. There is a list in last column of the table at http://en.wikipedia.org/wiki/Comparison_of_ARMv8-A_cores that needs to be worked in here. |
2b3d65a
to
5bc11ec
Compare
Added, but obviously untested. I think they are reasonably clear so can be merged without testing all cases. |
5bc11ec
to
f1798ca
Compare
Thanks, to merge there are two things that should be addressed:
These things are nice to have:
|
I don't think this needs to be addressed to merge. This is a bug (that was preexisting). I think we should create a bug in the issue tracker and address this separately. Doing that properly would be a refactor of the part lookup into a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good please add the missing DCO and consider squashing the commits.
The existing print_cpuid function displays the incorrect value for Cortex-A35. (See issue seL4#43). This change makes CPUID determination an explicit switch statement rather than attempting to automatically determine it through masking certain bits. Note: Only the Cortex-A35 case in the switch statement has been tested. Others cases are implemented from available lists only and have not been validated on real hardware. Sources: https://en.wikipedia.org/wiki/Comparison_of_ARMv8-A_cores seL4#107 (comment) Signed-off-by: Ben Leslie <benno@brkawy.com>
17b14d6
to
113bb1e
Compare
Done. |
The existing print_cpuid function displays the incorrect value for Cortex-A35. (See issue seL4#43). This change makes CPUID determination an explicit switch statement rather than attempting to automatically determine it through masking certain bits. Note: Only the Cortex-A35 case in the switch statement has been tested. Others cases are implemented from available lists only and have not been validated on real hardware. Sources: https://en.wikipedia.org/wiki/Comparison_of_ARMv8-A_cores seL4#107 (comment) Signed-off-by: Ben Leslie <benno@brkawy.com> GitOrigin-RevId: c5f0e54
The existing print_cpuid function displays the incorrect value
for Cortex-A35. (See issue #43).
This change makes CPUID determination an explicit switch statement
rather than attempting to automatically determine it through
masking certain bits.
Note: At some level this will be a regression as it now only
prints the textual id for Cortex-A35 and no other CPU.
Improvements to list other CPUID mappings is welcome, unfortunately
the only platform I have access to for testing is Cortex-A35.