elfloader/cmake-tool support for RPi4 #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am able to run seL4test on a RPi4 without any changes to the elfloader using the latest U-Boot, maybe older U-Boot versions did not support EFI images? |
Cherry-pick 'smp.c' and 'smp_head.S' from ARM Research IceCap repository for BCM2711 platform. Commit ID: b2b92939bf94443e7bf13a15801561ef7caf565d URL: https://gitlab.com/icecap-project/seL4_tools/-/commit/<SHA> UART support files are not selected from the commit, as kernel correctly generates header(s) for the 'bcm2835-aux-uart', which is the same as on RPi3, and the common 'bcm-uart.c' driver can be used for RPi4 too. Signed-off-by: Joonas Onatsu <joonasx@ssrc.tii.ae>
JoonasOnatsu
force-pushed
the
tii/sel4_tools_updates
branch
from
5619c1d
to
63819ac
Compare
Hi Ivan, thanks for your comment. I also tested with the latest U-Boot, and it seems that you are correct and the image can be booted with 'bootefi'. I think I had something misconfigured before, and I couldn't boot the image. I removed the commit for changing the image type. |
axel-h
reviewed
Nov 23, 2022
|
|
||
| extern void core_entry_head(unsigned long stack); | ||
|
|
||
| unsigned long core_stack; |
There was a problem hiding this comment.
If this holds an address, then we should simply say so.
Suggested change
| unsigned long core_stack; | |
| void *core_stack; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SMP support for RPi4 to
elfloader.