CMake: Work around a weird CMake bug #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue can be reproduced with this |
There's a weird interaction with a similar command in the capdl-loader in the capDL repository which causes CMake to ignore the platform_sift.py call in this repository. Merging the two `add_custom_command` calls tells CMake to not ignore it. Signed-off-by: Damon Lee <Damon.Lee@data61.csiro.au>
nomadeel
force-pushed
the
fix_ignored_call
branch
from
40de66e
to
f9a9912
Compare
sylGauthier
approved these changes
May 26, 2021
|
Well, I'll be happy to revisit it in the future, once things cool down in CI. I think I might even have some time to do it while waiting for CI to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a weird interaction with a similar command in the capdl-loader
in the capDL repository which causes CMake to ignore the
platform_sift.py call in this repository. Merging the two
add_custom_commandcalls tells CMake to not ignore it.Signed-off-by: Damon Lee Damon.Lee@data61.csiro.au