riscv: Add clear_bss to crt0 if image is binary #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary images do not have the luxury of having a proper loader load the elfloader into memory correctly and zero out the BSS, so we have to do it ourselves. Signed-off-by: Damon Lee <Damon.Lee@data61.csiro.au>
|
Where is clear bss? |
The SBI call clobbers a0 which is needed for the secondary_hart routine to check what the ID is of the HART that is currently running. Signed-off-by: Damon Lee <Damon.Lee@data61.csiro.au>
|
Added an extra commit for a fix that I found as well. |
kent-mcleod
reviewed
Jun 4, 2021
axel-h
reviewed
Jun 4, 2021
t3 is a temporary register and s0 is always preserved across calls (C function calls and ecalls) so we use s0 instead of a temporary register like t3. Signed-off-by: Damon Lee <Damon.Lee@data61.csiro.au>
|
Added a commit to use s0 instead of t3 for the HART ID. |
|
Can I get a review for this? I'm close to getting a release done and this is one of the blockers. |
kent-mcleod
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary images do not have the luxury of having a proper loader load
the elfloader into memory correctly and zero out the BSS, so we have to
do it ourselves.
Signed-off-by: Damon Lee Damon.Lee@data61.csiro.au