Add ODroid C4 support #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ODroid C4 as a valid device. Signed-off-by: Curtis Millar <curtis@curtism.me>
axel-h
reviewed
Jul 8, 2021
| reset_cntvoff(); | ||
| } | ||
|
|
||
| #if CONFIG_MAX_NUM_NODES > 1 |
There was a problem hiding this comment.
There is the alias ENABLE_SMP_SUPPORT that is also in use, is there a policy when to use what?
There was a problem hiding this comment.
On a 2nd look, seems this is only used in the kernel, but not in the ELF loader. So ignore that comment above.
There was a problem hiding this comment.
I think ENABLE_SMP_SUPPORT is only defined inside the kernel.
There was a problem hiding this comment.
It used to be, but then the kernel's private config file was moved into libsel4: https://github.com/seL4/seL4/blob/master/libsel4/include/sel4/config.h#L96
There was a problem hiding this comment.
Could be a thing for later then: #96
nomadeel
approved these changes
Jul 9, 2021
|
Looks good to me, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ODroid C4 as a valid device.