Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting / getting named joint states #65

Open
sea-bass opened this issue Jul 9, 2024 · 4 comments · May be fixed by #71
Open

Support setting / getting named joint states #65

sea-bass opened this issue Jul 9, 2024 · 4 comments · May be fixed by #71
Labels

Comments

@sea-bass
Copy link
Owner

sea-bass commented Jul 9, 2024

There should be an API to set/get joint states by name by storing them in dictionaries.

Additionally, this could support different groups, as well as loading the states from SRDF (which Pinocchio sort of already has).

@sea-bass sea-bass added the 2.0 label Jul 9, 2024
@henrygerardmoore
Copy link

I'm going to try this out :)

@sea-bass
Copy link
Owner Author

sea-bass commented Sep 8, 2024

Awesome, looking forward to it!

Although it might make things easier to start with an attempt at #56, since ideally named states could pertain to a subset of joints.

This probably won't be super straightforward, but I suspect it requires a wrapper around the models to manage joint indices and the like. I left a blank placeholder for something like this in https://github.com/sea-bass/pyroboplan/blob/main/src/pyroboplan/core/planning_context.py, if you wanna give it a try and fill it partially?

@henrygerardmoore
Copy link

Yes, I'd like to give that a try! I actually already finished a super rudimentary setting/getting joint states API which is basically a dict wrapper with some added convenience functions + an example (didn't take into account any joint groups), but it makes sense that starting with joint groups should come first. I'll maybe make a draft PR of that so you can just give it a quick look over and see if it captures your intent with this issue, and then update it once I've made an attempt at #56. Does that seem like a good approach?

@sea-bass
Copy link
Owner Author

sea-bass commented Sep 8, 2024

SGTM, thanks @henrygerardmoore!

@henrygerardmoore henrygerardmoore linked a pull request Sep 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants