-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code formatting in CI #59
Conversation
Thanks for kicking this off! This might end up being a bigger PR than expected, since adding a GitHub action to run Black means all the code will have to be auto-formatted :) |
The Github action seems to be working for black. |
@sea-bass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started!
I meant to do this and have a lot of particular preferences (sorry), so here you go :)
Looks like it is working directly with pre-commit now. |
Yes they are, this is so cool to see! I'll leave it up to you if you want to actually do all the formatting changes; else, we can merge this as-is and I can update with the suggestions in a follow-on PR. |
Do you mean the formatting changes suggested by Black ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small stuff.
Again, I'm happy to approve it after this if you don't want to actually commit the formatting suggestions as part of this PR, but up to you.
No problem. will add the suggested changes by Black to this PR itself. |
Maybe you already know this, but just in case! If you install
it will do all the changes automatically. |
The Format workflow is failing since this branch was made before the world modeling tests were merged and so does not include the 'test_world.py' which is in main. |
You can merge my repo's Also, I guess pre-commit doesn't automatically add shebangs to shell scripts. Added those too. |
It passed ! |
If the Thank you so much for doing this! |
Will close #55