New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pip dependencies to setup #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this!
I was able to create a fresh Python 3.8 virtualenv, pip install
just this package, and it worked with the exception of the ROS example which additionally requires transforms3d
.
One thing you could test for the ROS workflow is:
- Go to
setup/create_python_env.bash
- Replace line 15 with simply a
pip install $SCRIPT_DIR/..
, or whatever points to the pyrobosim folder. - Do things work that way if you then start a fresh Terminal and
source setup/setup_pyrobosim.bash
? If so you could consider changing this in the PR too. I tried and this worked for me, at least.
Beyond that, just minor formatting comments and should be good after.
Oh also, can you just merge this into |
@ibrahiminfinite I think you need to rebase because right now this PR is trying to merge all the commits from my PRM/RRT branch plus yours on top. Notice the PR says there are 17 commits. The best way to fix this is to go into your branch and go:
If all went well, then you should see this PR come back down to 4 commits. |
Co-authored-by: Sebastian Castro <sebas.a.castro@gmail.com>
Co-authored-by: Sebastian Castro <sebas.a.castro@gmail.com>
Sorry about that, have dropped the path planner commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.