Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip dependencies to setup #6

Merged
merged 4 commits into from May 28, 2022
Merged

Conversation

ibrahiminfinite
Copy link
Collaborator

No description provided.

@sea-bass sea-bass self-requested a review May 27, 2022 01:34
Copy link
Owner

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!

I was able to create a fresh Python 3.8 virtualenv, pip install just this package, and it worked with the exception of the ROS example which additionally requires transforms3d.

One thing you could test for the ROS workflow is:

  • Go to setup/create_python_env.bash
  • Replace line 15 with simply a pip install $SCRIPT_DIR/.. , or whatever points to the pyrobosim folder.
  • Do things work that way if you then start a fresh Terminal and source setup/setup_pyrobosim.bash? If so you could consider changing this in the PR too. I tried and this worked for me, at least.

Beyond that, just minor formatting comments and should be good after.

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@sea-bass
Copy link
Owner

Oh also, can you just merge this into main instead? It's probably cleaner to work directly off the main branch.

@sea-bass sea-bass added the tools Software tools and infrastructure label May 27, 2022
@ibrahiminfinite ibrahiminfinite changed the base branch from rrt_prm_planners to main May 28, 2022 02:43
@sea-bass
Copy link
Owner

@ibrahiminfinite I think you need to rebase because right now this PR is trying to merge all the commits from my PRM/RRT branch plus yours on top. Notice the PR says there are 17 commits.

The best way to fix this is to go into your branch and go:

  • git rebase -i origin/main
  • Go through the prompts
  • git push -f origin HEAD

If all went well, then you should see this PR come back down to 4 commits.

ibrahiminfinite and others added 4 commits May 28, 2022 15:40
Co-authored-by: Sebastian Castro <sebas.a.castro@gmail.com>
Co-authored-by: Sebastian Castro <sebas.a.castro@gmail.com>
@ibrahiminfinite
Copy link
Collaborator Author

@ibrahiminfinite I think you need to rebase because right now this PR is trying to merge all the commits from my PRM/RRT branch plus yours on top. Notice the PR says there are 17 commits.

The best way to fix this is to go into your branch and go:

  • git rebase -i origin/main
  • Go through the prompts
  • git push -f origin HEAD

If all went well, then you should see this PR come back down to 4 commits.

Sorry about that, have dropped the path planner commits.
It is just the setup commits now.

@sea-bass sea-bass self-requested a review May 28, 2022 10:13
Copy link
Owner

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sea-bass sea-bass merged commit 9414953 into sea-bass:main May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Software tools and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants