Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Work with "delight" for major modes #202

Closed
alienbogart opened this issue Jul 31, 2019 · 5 comments
Closed

Request: Work with "delight" for major modes #202

alienbogart opened this issue Jul 31, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@alienbogart
Copy link

Runtime Environment

Issue

Is your feature request related to a problem? Please describe.

delight does not for major modes.

Example:

(use-package org
  :ensure nil
  :delight)

Keeps Org in the modeline.

None of these work with doom-modeline either:

(use-package delight
  :ensure t
  :config
  (delight '(
             (projectile-mode nil)
             (sh-mode " sh " "Shell-script[bash]")
             (org-mode "" "Org")
             (Org-Src "" "OrgSrc")
             (overwrite-mode " Ovl" t)
             (special-mode " special" "special")
             (message-mode " messages" "Messages")
             (markdown-mode " md" "Markdown")
             (emacs-lisp-mode "" "*Org.**")
             (fundamental-mode " fund" "Fundamental")
             (web-mode " web" "Web")
             (undo-tree-mode " " "Undo-Tree")
             (super-save-mode "" "super-save")
             (counsel-mode "" "counsel")
             (abbrev-mode "" "Abbrev")
             (evil-org-mode "" " EvilOrg")
             (elmacro-mode " " "elmacro")
             (ivy-mode "" "ivy")
             (python-mode " Py" " Python")
             (emacs-lisp-mode " elisp" "Emacs-Lisp")
             (lisp-interaction-mode " lisp int" "Lisp Interaction"))))

Describe the solution you'd like

For delight to work with doom-modeline.

Describe alternatives you've considered

I also tried the package rich-minority.

Is your feature request related to a problem? Please describe.

Yes, supporting delight directly solves the issue.

@seagle0128 seagle0128 added the enhancement New feature or request label Aug 1, 2019
@seagle0128
Copy link
Owner

According to the codes, delight advices format-mode-line which is really tricky for mode-name. powerline is also incompatible with it.

Now I am trying to avoid using format-mode-line for major-mode and minor-mode-alist. Please test the new version.

@alienbogart
Copy link
Author

Thank you but I'm not sure I understand. What you mean by "test the new version"? I updated all my packages and it still doesn't work:

  • doom-modeline: 20190801.1802
  • delight: 1.5

seagle0128 added a commit that referenced this issue Aug 3, 2019
@seagle0128
Copy link
Owner

I committed a new change with another solution. Please test.

@alienbogart
Copy link
Author

alienbogart commented Aug 3, 2019

Was it submited on Melpa or just here on the repository?

@alienbogart
Copy link
Author

Okay, it's working flawlessly now. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants