[Bug] Clipped org mode tag menu

[memeplex]

Thank you for the bug report

• I am using the latest version of doom-mode related packages.
• I checked FAQ.
• You may also try reproduce the issue using clean environment and minimal configurations with
  the command emacs -Q.

Bug description

I'm reporting this again because it is not fixed: #291

Screen.Recording.2021-10-15.at.00.34.56.mov

Steps to reproduce

1. Start emacs with only doom-modeline installed, just the vanilla config
2. Create an org file with the contents below
3. Press C-c C-c over the first line
4. Press C-c C-q over the text "headline"
5. Press C-g to exit the tag popup
6. Repeat step 4

#+TAGS: @work(w)  @home(h)  @tennisclub(t)  laptop(l)  pc(p)

* headline

Expected behavior

org-mode tag menu is properly presented.

OS

MacOS

Emacs Version

28

Emacs Configurations

No response

Error callstack

No response

Anything else

This happens with and without icons enabled.

Once it happens it stays there until restart.

Whatever is being done by doom-emacs to fix it is a downstream hack and not a proper solution.

[memeplex]

I've been doing some tests with moody too and realized that:

the first time the completion popup opens it's properly sized, it's after the first time that it gets clipped and then stays like that. So maybe the underlying reason is different, since I can't see how a missing call to redisplay won't affect the first popup but will break the layout of next one. Therefore I disabled the "just once" behavior (hacked-p) and it fixes the immediate problem. That said, I don't know the implications of redisplaying each time fit-window-to-buffer is called, but it's apparent that the hack stop working at some time.

[tarsius]

It's kinda funny that the video is of no help to me (on firefox) because the part where the mode-line is covering parts of the above buffer is in turn covered by the video player controls. 🤣

[memeplex]

It's kinda funny that the video is of no help of me (on firefox) because the part where the mode-line is covering parts of the above buffer is in turn covered by the video player controls. 🤣

LOL indeed, it seems the redisplay is not helping firefox either.

[memeplex]

The cleanest recipe I found that still reproduces the issue is based on your example in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38181#5:

1. Execute the code in said example.
2. Call test-popup and check that the layout is wrong.
3. Redefine test-popup with (redisplay) uncommented.
4. Call it again and check that the layout is right.
5. Redefine test-popup with (redisplay) commented again.
6. Call it again and check that the layout is wrong again.

So, if fit = fit-window-to-buffer, after prettifying the modeline we had the offending sequence:

• fit fit fit ...

which was solved by a initial redisplay:

• redisplay fit fit ...

but now it seems to be necessary to run the redisplay before each fit:

• redisplay fit redisplay fit redisplay fit ...

Or perhaps it was always necessary in my setup, I'm not able to say whether this is a regression or not because I was using the stock modeline until now.

[memeplex]

See also this related issue tarsius/moody#34. The more I delve into it, the more similar the underlying causes look. I'm close to a solution but I'm (painfully) trying to validate my assumptions with upstream.

[seagle0128]

Close it by #484 .