Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test case for list image in charts #1990

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

amirrmonfared
Copy link
Contributor

Signed-off-by: amirrmonfared amirrmonfared@outlook.com

Signed-off-by: amirrmonfared <amirrmonfared@outlook.com>
@github-actions github-actions bot added ImageBuilding related to all staff with image building test labels Jan 24, 2023
@amirrmonfared
Copy link
Contributor Author

/cc @starnop @kakaZhou719

@codecov-commenter
Copy link

Codecov Report

Base: 17.61% // Head: 17.71% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (a9d4661) compared to base (e412c60).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1990      +/-   ##
==========================================
+ Coverage   17.61%   17.71%   +0.09%     
==========================================
  Files         105      105              
  Lines        9468     9468              
==========================================
+ Hits         1668     1677       +9     
+ Misses       7573     7563      -10     
- Partials      227      228       +1     
Impacted Files Coverage Δ
build/layerutils/charts/charts.go 75.00% <0.00%> (+75.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@starnop
Copy link
Collaborator

starnop commented Jan 30, 2023

LGTM

@starnop
Copy link
Collaborator

starnop commented Jan 30, 2023

@amirrmonfared Thanks for your nice job.

@starnop starnop merged commit 9566275 into sealerio:main Jan 30, 2023
@amirrmonfared amirrmonfared deleted the chart-unit-test branch January 30, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ImageBuilding related to all staff with image building test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants