Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set CustomImageName to change TestImage and fix code #2012

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

zhy76
Copy link
Member

@zhy76 zhy76 commented Feb 3, 2023

Signed-off-by: zhy76 958474674@qq.com

Describe what this PR does / why we need it

Change the test image requires changing all the relevant image names in the code, which is not very convenient. So, we can set an environment variable that changes only that variable to modify test image.
And after this PR, we can export an environment variable named IMAGE_NAME to modify all test image

Does this pull request fix one issue?

#2011

Describe how you did it

Describe how to verify it

Special notes for reviews

Signed-off-by: zhy76 <958474674@qq.com>
@github-actions github-actions bot added e2e-test it needs to run e2e test test labels Feb 3, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 17.72% // Head: 17.72% // No change to project coverage 👍

Coverage data is based on head (89e22ee) compared to base (2cd5bb8).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2012   +/-   ##
=======================================
  Coverage   17.72%   17.72%           
=======================================
  Files         105      105           
  Lines        9469     9469           
=======================================
  Hits         1678     1678           
  Misses       7563     7563           
  Partials      228      228           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kakaZhou719 kakaZhou719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kakaZhou719 kakaZhou719 merged commit 5e6c0d0 into sealerio:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-test it needs to run e2e test test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants