Bugfix multi image support #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ImageBuilding
Codecov ReportBase: 18.40% // Head: 18.34% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2019 +/- ##
==========================================
- Coverage 18.40% 18.34% -0.06%
==========================================
Files 101 101
Lines 9201 9225 +24
==========================================
- Hits 1693 1692 -1
- Misses 7277 7302 +25
Partials 231 231
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kakaZhou719
force-pushed
the
bufix-multi-image-support
branch
2 times, most recently
from
59b037e
to
b37db58
Compare
|
pls rebase commits |
Stevent-fei
reviewed
Feb 7, 2023
kakaZhou719
force-pushed
the
bufix-multi-image-support
branch
2 times, most recently
from
83519b0
to
b790c77
Compare
starnop
reviewed
Feb 8, 2023
| // if arch is amd64 | ||
| // `COPY ${ARCH}/* .` will be mutated to `COPY amd64/* .` | ||
| // `COPY $ARCH/* .` will be mutated to `COPY amd64/* .` | ||
| _, arch, _, err := parse2.Platform(kp.platform) |
There was a problem hiding this comment.
could we add unit tests for these logic?
starnop
reviewed
Feb 8, 2023
| @@ -53,6 +53,6 @@ func NewPushCmd() *cobra.Command { | |||
| // tls-verify is not working currently | |||
| pushCmd.Flags().BoolVar(&pushOpts.TLSVerify, "tls-verify", true, "require HTTPS and verify certificates when accessing the registry. TLS verification cannot be used when talking to an insecure registry. (not work currently)") | |||
| pushCmd.Flags().BoolVarP(&pushOpts.Quiet, "quiet", "q", false, "don't output progress information when pushing images") | |||
| pushCmd.Flags().BoolVar(&pushOpts.All, "all", false, "also push the images in the list") | |||
| pushCmd.Flags().BoolVar(&pushOpts.All, "all", true, "also push the images in the list") | |||
There was a problem hiding this comment.
it is just push command, i thought there will be no impact.
|
Could you please add e2e tests for this PR？ |
kakaZhou719
commented
Feb 9, 2023
test/suites/build/build.go
Outdated
| return filepath.Join(settings.DefaultTestEnvDir, "suites", "build", "fixtures") | ||
| // GetBuildImageName return specific image name for sealer build test | ||
| func GetBuildImageName() string { | ||
| return "docker.io/sealerio/forbuildtest:v1" |
There was a problem hiding this comment.
docker.io/sealerio/build-test:v1 is OK
added 2 commits
February 13, 2023 18:15
bugfix: not panic if user wite invalid copy fix lint add e2e test for sealer build disable wrapper.IgnoreFile for build
kakaZhou719
force-pushed
the
bufix-multi-image-support
branch
from
cd7ea89
to
8855b23
Compare
|
/test all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Kubefile:
FROM registry.cn-qingdao.aliyuncs.com/sealer-io/ackdistro-multi:v0.4.0 COPY ${ARCH}/bin bin APP myapp local://app.yaml LAUNCH myappbuild context
build multi image:
sealer build -f Kubefile -t my-kubernetes:1.19.8 --platform linux/amd64,linux/arm64tag and push all images to docker hub:
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews