Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mixed app type with appcmds #2028

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

kakaZhou719
Copy link
Member

@kakaZhou719 kakaZhou719 commented Feb 14, 2023

Describe what this PR does / why we need it

kubefile:

FROM scratch
APP yamlapp local://yamlcontext
APP shellapp local://shellcontext
APP mixedapp local://install.sh local://mixedcontext
APPCMDS mixedapp ["kubectl apply -f app.yaml"]
LAUNCH ["mixedapp","shellapp"]
├── context
│   ├── app.yaml
│   └── install.sh
├── install.sh
├── Kubefile
├── shellcontext
│   ├── a.sh
│   ├── b.sh
│   └── c.sh
└── yamlcontext
    ├── a.yaml
    ├── b.yaml
    └── c.yaml

if app build context is mixed, need to specify APPCMDS if no app type is detected.

Does this pull request fix one issue?

fixes #1993

Describe how you did it

Describe how to verify it

Special notes for reviews

@github-actions github-actions bot added e2e-test it needs to run e2e test ImageBuilding related to all staff with image building test labels Feb 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Base: 18.34% // Head: 18.58% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (280bf8c) compared to base (462034d).
Patch coverage: 25.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2028      +/-   ##
==========================================
+ Coverage   18.34%   18.58%   +0.23%     
==========================================
  Files         101      101              
  Lines        9222     9222              
==========================================
+ Hits         1692     1714      +22     
+ Misses       7299     7279      -20     
+ Partials      231      229       -2     
Impacted Files Coverage Δ
build/kubefile/parser/utils.go 61.00% <9.09%> (+10.68%) ⬆️
build/kubefile/parser/kubefile.go 34.98% <32.00%> (+1.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kakaZhou719 kakaZhou719 force-pushed the bugfix-app-get-app-type-and-files branch from 17ddae8 to bbf41b6 Compare February 14, 2023 02:37
@starnop
Copy link
Collaborator

starnop commented Feb 15, 2023

/test all

@zhy76
Copy link
Member

zhy76 commented Feb 15, 2023

/test run

2 similar comments
@zhy76
Copy link
Member

zhy76 commented Feb 16, 2023

/test run

@starnop
Copy link
Collaborator

starnop commented Feb 16, 2023

/test run

Copy link
Collaborator

@starnop starnop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starnop starnop merged commit 7cc3c3e into sealerio:main Feb 21, 2023
@kakaZhou719 kakaZhou719 deleted the bugfix-app-get-app-type-and-files branch March 8, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-test it needs to run e2e test ImageBuilding related to all staff with image building test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] An app cannot contain different types of files
4 participants