fix:GitHub action for e2e-test_comment doesn't show in checks for PR #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starnop
reviewed
Feb 14, 2023
| sudo sysctl net/netfilter/nf_conntrack_max=131072 | ||
| ginkgo -v --focus="sealer apply" test | ||
|
|
||
| - name: Set final commit status |
There was a problem hiding this comment.
Is there any conflict in setting status for multiple tasks concurrently?
There was a problem hiding this comment.
No, It only change the final status to the right value(fail or success).
Signed-off-by: zhy76 <958474674@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhy76 958474674@qq.com
Describe what this PR does / why we need it
fix:GitHub action for e2e-test_comment doesn't show in checks for PR, after this PR, we can use comment like:"/test all","/test run" to trigger CI and see checks on PR.
Does this pull request fix one issue?
#2030
Describe how you did it
Describe how to verify it
Special notes for reviews