test: add sealer alpha mount/umount e2e test #2033
Conversation
Stevent-fei
force-pushed
the
add_e2e_mount_test
branch
from
579b20f
to
58ceb00
Compare
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2033 +/- ##
=======================================
Coverage 19.29% 19.29%
=======================================
Files 96 96
Lines 8985 8985
=======================================
Hits 1734 1734
Misses 7026 7026
Partials 225 225 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/test all |
Stevent-fei
changed the title
|
/test all |
Stevent-fei
force-pushed
the
add_e2e_mount_test
branch
from
4dc630a
to
64dba11
Compare
Stevent-fei
changed the title
.github/workflows/e2e-test-mount.yml
Outdated
| @@ -0,0 +1,65 @@ | |||
| name: Sealer-Test-Mount | |||
There was a problem hiding this comment.
Mount is a sub command for image ,i think we only need add it to image e2e test
test/sealer_mount_test.go
Outdated
|
|
||
| By("start to umount a image") | ||
| umountCmd := fmt.Sprintf("%s alpha umount %s -d", settings.DefaultSealerBin, settings.TestImageName) | ||
| testhelper.RunCmdAndCheckResult(umountCmd, 0) |
There was a problem hiding this comment.
could we check more details of mount, such as mounted dir exiting , or image file.
Stevent-fei
force-pushed
the
add_e2e_mount_test
branch
from
1b0ebc7
to
908e6f3
Compare
test/sealer_images_test.go
Outdated
| mountCmd := fmt.Sprintf("%s alpha mount %s %s %s -d", settings.DefaultSealerBin, settings.TestImageName, settings.TestK8s120, settings.TestK8s118) | ||
| testhelper.RunCmdAndCheckResult(mountCmd, 0) | ||
|
|
||
| err := filepath.WalkDir("/var/lib/containers/storage/overlay", func(path string, d fs.DirEntry, err error) error { |
There was a problem hiding this comment.
why "/var/lib/containers/storage/overlay" , make it const or get it from imageengine ?
test/sealer_images_test.go
Outdated
| } | ||
|
|
||
| By("start to umount multiple images") | ||
| umountCmd := fmt.Sprintf("%s alpha umount %s %s %s -d", settings.DefaultSealerBin, settings.TestImageName, settings.TestK8s120, settings.TestK8s118) |
There was a problem hiding this comment.
add test case for mount multi app images
Stevent-fei
force-pushed
the
add_e2e_mount_test
branch
3 times, most recently
from
d6e2899
to
d8bb659
Compare
Stevent-fei
force-pushed
the
add_e2e_mount_test
branch
from
ccdb7ea
to
a287232
Compare
Describe what this PR does / why we need it
add sealer alpha mount/umount e2e test
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews