Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: delete useless code #2058

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

Stevent-fei
Copy link
Collaborator

@Stevent-fei Stevent-fei commented Feb 23, 2023

Describe what this PR does / why we need it

delete useless code of build and pkg module

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@github-actions github-actions bot added ImageBuilding related to all staff with image building test labels Feb 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Base: 18.64% // Head: 19.45% // Increases project coverage by +0.81% 🎉

Coverage data is based on head (590883b) compared to base (af34af6).
Patch has no changes to coverable lines.

❗ Current head 590883b differs from pull request most recent head 3336b6d. Consider uploading reports for the commit 3336b6d to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2058      +/-   ##
==========================================
+ Coverage   18.64%   19.45%   +0.81%     
==========================================
  Files          99       96       -3     
  Lines        9179     8785     -394     
==========================================
- Hits         1711     1709       -2     
+ Misses       7243     6853     -390     
+ Partials      225      223       -2     
Impacted Files Coverage Δ
build/layerutils/manifests/manifests.go 0.00% <ø> (ø)
pkg/config/config.go 27.95% <ø> (ø)
build/buildimage/differ.go
build/buildimage/middleware.go
build/buildimage/utils.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kakaZhou719 kakaZhou719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ImageBuilding related to all staff with image building test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants