Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:delete tmp build dir #2069

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

kakaZhou719
Copy link
Member

Describe what this PR does / why we need it

Does this pull request fix one issue?

fixes #1986

Describe how you did it

Describe how to verify it

Special notes for reviews

@github-actions github-actions bot added the ImageBuilding related to all staff with image building label Feb 28, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 18.34% // Head: 18.34% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (f5f11d7) compared to base (317c4b9).
Patch coverage: 0.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2069      +/-   ##
==========================================
- Coverage   18.34%   18.34%   -0.01%     
==========================================
  Files          99       99              
  Lines        9327     9323       -4     
==========================================
- Hits         1711     1710       -1     
+ Misses       7391     7388       -3     
  Partials      225      225              
Impacted Files Coverage Δ
build/kubefile/parser/app_handler.go 48.05% <0.00%> (+1.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@starnop starnop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nice job 👍

@starnop starnop merged commit d326141 into sealerio:main Mar 1, 2023
@kakaZhou719 kakaZhou719 deleted the bugfix-delete-tmp-build-dir branch March 8, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ImageBuilding related to all staff with image building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APP instruction with remote file address will generate tmp files sealer-remote-filesxxx
3 participants