Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new k8s registry #2074

Merged
merged 1 commit into from
Mar 3, 2023
Merged

use new k8s registry #2074

merged 1 commit into from
Mar 3, 2023

Conversation

yuvraj9
Copy link
Contributor

@yuvraj9 yuvraj9 commented Mar 1, 2023

Fixes - #2073

Problem: Previously all of Kubernetes' image hosting has been out of gcr.io. There were significant egress costs associated with this when images were pulled from entities outside gcp. Refer to https://github.com/kubernetes/k8s.io/wiki/New-Registry-url-for-Kubernetes-(registry.k8s.io)

Solution: As highlighted at KubeCon NA 2022 k8s infra SIG update, the replacement for k8s.gcr.io which is registry.k8s.io is now ready for mainstream use and the old k8s.gcr.io has been formally deprecated and projects are requested to migrate off it. This commit migrates remaining references for kubevirt/hostpath-provisioner to registry.k8s.io.

Which issue(s) this PR fixes
Relates to umbrella issue kubernetes/k8s.io#4780

@github-actions github-actions bot added area/doc ImageBuilding related to all staff with image building test labels Mar 1, 2023
Signed-off-by: yuvraj singh shekhawat <shekhawatyuvraj1998@gmail.com>
@yuvraj9
Copy link
Contributor Author

yuvraj9 commented Mar 1, 2023

I have also raised pull requests in sealerio/applications#10 and sealerio/basefs#44

Copy link
Collaborator

@starnop starnop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (2260571) 18.36% compared to head (9d3ad39) 18.36%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2074   +/-   ##
=======================================
  Coverage   18.36%   18.36%           
=======================================
  Files         100      100           
  Lines        9313     9313           
=======================================
  Hits         1710     1710           
  Misses       7378     7378           
  Partials      225      225           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doc ImageBuilding related to all staff with image building test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants