Optimize code for run apps #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test run |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2076 +/- ##
==========================================
+ Coverage 18.36% 18.63% +0.27%
==========================================
Files 100 99 -1
Lines 9313 9234 -79
==========================================
+ Hits 1710 1721 +11
+ Misses 7378 7287 -91
- Partials 225 226 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kakaZhou719
force-pushed
the
optimize-code-apps
branch
2 times, most recently
from
3549131
to
16359da
Compare
|
/test all |
starnop
reviewed
Mar 2, 2023
cmd/sealer/cmd/cluster/run.go
Outdated
| appNames := infraDriver.GetClusterLaunchApps() | ||
|
|
||
| // merge to application between v2.ClusterSpec, v2.Application and image extension | ||
| v2App, err := application.NewV2Application(v2.ConstructApplication(cf.GetApplication(), cmds, appNames), imageSpec.ImageExtension) |
There was a problem hiding this comment.
i thought , if init app error ,return fast.
kakaZhou719
force-pushed
the
optimize-code-apps
branch
from
16359da
to
b20b5b0
Compare
optimize code for run apps
kakaZhou719
force-pushed
the
optimize-code-apps
branch
from
b20b5b0
to
1ae912c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews