Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize something #2079

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

starnop
Copy link
Collaborator

@starnop starnop commented Mar 6, 2023

Describe what this PR does / why we need it

  1. optimize the error log with the reason for failing to pull the Seaelr Image
  2. we should expose any interface definitions including the constants we use

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

Signed-off-by: 煜星 <yuxing.lyx@alibaba-inc.com>
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (2b4c47a) 19.31% compared to head (2f8af03) 19.31%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2079   +/-   ##
=======================================
  Coverage   19.31%   19.31%           
=======================================
  Files          96       96           
  Lines        8978     8978           
=======================================
  Hits         1734     1734           
  Misses       7019     7019           
  Partials      225      225           
Impacted Files Coverage Δ
pkg/clusterfile/clusterfile.go 25.34% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kakaZhou719 kakaZhou719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants