Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add upgrade cmd #2081

Merged
merged 1 commit into from
Mar 7, 2023
Merged

add upgrade cmd #2081

merged 1 commit into from
Mar 7, 2023

Conversation

wizardlyk
Copy link
Collaborator

Describe what this PR does / why we need it

change upgrade mode to cmd, support upgrade with cluster file

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (7ba6fff) 19.31% compared to head (5861f98) 19.29%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2081      +/-   ##
==========================================
- Coverage   19.31%   19.29%   -0.02%     
==========================================
  Files          96       96              
  Lines        8978     8985       +7     
==========================================
  Hits         1734     1734              
- Misses       7019     7026       +7     
  Partials      225      225              
Impacted Files Coverage Δ
pkg/clusterfile/decoder.go 51.78% <0.00%> (-2.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wizardlyk wizardlyk force-pushed the add-upgrade-cmd branch 2 times, most recently from 521e29a to c016f4d Compare March 6, 2023 12:19
@wizardlyk wizardlyk force-pushed the add-upgrade-cmd branch 2 times, most recently from 07dc2ff to 0714808 Compare March 7, 2023 04:58
Signed-off-by: wb-lyk925458 <wb-lyk925458@alibaba-inc.com>
Copy link
Collaborator

@VinceCui VinceCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants