[DOC]: replace ClusterImage to sealer image #2104
Conversation
Stevent-fei
force-pushed
the
fix_push_bug
branch
from
83e3a70
to
df8710c
Compare
cmd/sealer/cmd/image/push.go
Outdated
| pushOpts.Image = args[0] | ||
| return engine.Push(pushOpts) | ||
|
|
||
| if login { |
There was a problem hiding this comment.
i dont agree add check whether user is login in here . what if user push to registry that is not require authentication.
| @@ -34,18 +38,29 @@ var exampleForPushCmd = ` | |||
| func NewPushCmd() *cobra.Command { | |||
| pushCmd := &cobra.Command{ | |||
| Use: "push", | |||
| Short: "push ClusterImage to remote registry", | |||
| Short: "push sealer image to remote registry", | |||
There was a problem hiding this comment.
good code describes . so , could we walkthrough all sealer cmd description to replace ClusterImage to sealer image.
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2104 +/- ##
==========================================
+ Coverage 18.68% 18.79% +0.11%
==========================================
Files 95 96 +1
Lines 8874 8921 +47
==========================================
+ Hits 1658 1677 +19
- Misses 6995 7017 +22
- Partials 221 227 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Stevent-fei
changed the title
Stevent-fei
force-pushed
the
fix_push_bug
branch
2 times, most recently
from
453259b
to
17bfb88
Compare
|
/test build |
kakaZhou719
changed the title
|
@Stevent-fei , could we check the entire cmd directory? not only image dir. |
Stevent-fei
force-pushed
the
fix_push_bug
branch
from
17bfb88
to
7e04ede
Compare
|
|
Stevent-fei
force-pushed
the
fix_push_bug
branch
from
cf51a18
to
0958333
Compare
Describe what this PR does / why we need it
replace ClusterImage to sealer image.
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews