Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip run app via clusterfile Or run CLI #2117

Merged

Conversation

kakaZhou719
Copy link
Member

@kakaZhou719 kakaZhou719 commented Mar 16, 2023

Describe what this PR does / why we need it

for sealer run:

sealer run abc:v1 --apps "" : will skip
sealer run abc:v1 --apps "fake app" : will return error
sealer run abc:v1 --apps "real app": will launch 

for clusterfile: will skip launch app when appNames = [""]

apiVersion: sealer.io/v2
kind: Cluster
metadata:
  creationTimestamp: null
  name: my-cluster
spec:
  appNames: [""]
  hosts:
  - ips:
    - 172.16.26.165
    roles:
    - master
    ssh: {}
  image: localhost/abc:v1
  ssh:
    passwd: aaaaaa
    pk: /root/.ssh/id_rsa
    port: "22"
    user: root

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@starnop
Copy link
Collaborator

starnop commented Mar 16, 2023

sealer run abc:v1 --apps "fake app" : will skip

return error?

skip run app via clusterfile Or run CLI
@kakaZhou719 kakaZhou719 force-pushed the feat-support-skip-run-app-via-clusterfile branch from 6eedab3 to 2af7f2e Compare March 16, 2023 06:51
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (4ecebf3) 18.89% compared to head (2af7f2e) 18.90%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2117   +/-   ##
=======================================
  Coverage   18.89%   18.90%           
=======================================
  Files          95       95           
  Lines        8890     8897    +7     
=======================================
+ Hits         1680     1682    +2     
- Misses       6982     6985    +3     
- Partials      228      230    +2     
Impacted Files Coverage Δ
pkg/application/v2app.go 29.31% <44.44%> (-0.03%) ⬇️
cmd/sealer/cmd/utils/application.go 60.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@starnop starnop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starnop starnop merged commit d584e8e into sealerio:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants