Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat support skip-tls-verify flag for pull push login #2118

Merged

Conversation

kakaZhou719
Copy link
Member

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (4ecebf3) 18.89% compared to head (7a4d422) 18.87%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2118      +/-   ##
==========================================
- Coverage   18.89%   18.87%   -0.02%     
==========================================
  Files          95       95              
  Lines        8890     8899       +9     
==========================================
  Hits         1680     1680              
- Misses       6982     6991       +9     
  Partials      228      228              
Impacted Files Coverage Δ
pkg/imageengine/buildah/login.go 0.00% <0.00%> (ø)
pkg/imageengine/buildah/manifest.go 0.00% <0.00%> (ø)
pkg/imageengine/buildah/pull.go 0.00% <0.00%> (ø)
pkg/imageengine/buildah/push.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@VinceCui VinceCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants