Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get secret none #2122

Merged
merged 1 commit into from
Mar 17, 2023
Merged

fix get secret none #2122

merged 1 commit into from
Mar 17, 2023

Conversation

zhy76
Copy link
Member

@zhy76 zhy76 commented Mar 17, 2023

Describe what this PR does / why we need it

fix get secret none because pull_request event can't get github SECERT, this will cause sealer login failed.

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

Signed-off-by: zhy76 <958474674@qq.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (9bb277b) 18.87% compared to head (f91ed06) 18.88%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2122   +/-   ##
=======================================
  Coverage   18.87%   18.88%           
=======================================
  Files          95       95           
  Lines        8899     8906    +7     
=======================================
+ Hits         1680     1682    +2     
- Misses       6991     6994    +3     
- Partials      228      230    +2     
Flag Coverage Δ
unit-tests 18.88% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/application/v2app.go 29.31% <44.44%> (-0.03%) ⬇️
cmd/sealer/cmd/utils/application.go 60.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kakaZhou719 kakaZhou719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakaZhou719 kakaZhou719 merged commit 833f07a into sealerio:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants